formManager.constructor - Code Metrics - Inspection of "Remove password picker upon saving credentials" - nextcloud/passman-webextension - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#161)

by Sander

created 2017-08-12 12:48 UTC

formManager.constructor B

↳ Parent: js/lib/findForm.js

Complexity

Conditions	1
Paths	96

Size

Total Lines

170

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
c	1
b	0
f	0
nc	96
nop	0
dl	0
loc	170
rs	8.2857

6 Functions

Rating	Name	Size	Complexity
A	formManager._init_	5	1
C	formManager._getPasswordFields	31	7
A	formManager._init_	3	1
A	formManager.isAutocompleteDisabled	3	1
A	formManager.log	5	2
D	formManager.getFormFields	84	17

How to fix Long Method

var formManager = function(){
    /**
     Code based on:
     @url https://dxr.mozilla.org/firefox/source/toolkit/components/passwordmgr/src/nsLoginManager.js#655
     */
    var settings = {};

    return {
        _init_: function () {
            API.runtime.sendMessage(API.runtime.id, {method: 'getSetting', args: 'debug'}).then(function (result) {
                settings.debug = (result);
            });
        },
        /*
         * _isAutoCompleteDisabled
         *
         * Returns true if the page requests autocomplete be disabled for the
         * specified form input.
         */
        isAutocompleteDisabled: function (element) {
            return !!(element && element.hasAttribute("autocomplete") && element.getAttribute("autocomplete").toLowerCase() === "off");
        },

        /*
         * _getPasswordFields
         *
         * Returns an array of password field elements for the specified form.
         * If no pw fields are found, or if more than 3 are found, then null
         * is returned.
         *
         * skipEmptyFields can be set to ignore password fields with no value.
         */
        _getPasswordFields: function (form, skipEmptyFields) {
            // Locate the password fields in the form.
            var pwFields = [];
            for (var i = 0; i < form.elements.length; i++) {
                if (form.elements[i].type !== "password"){
                    continue;
                }


                if (skipEmptyFields && !form.elements[i].value){
                    continue;
                }

                pwFields[pwFields.length] = {
                    index: i,
                    element: form.elements[i]
                };
            }

            // If too few or too many fields, bail out.
            if (pwFields.length === 0) {
                this.log('(form ignored ('+ form.action +') -- no password fields.)');
                return null;
            } else if (pwFields.length > 3) {
                this.log('(form ignored -- too many password fields. [got ' +
                    pwFields.length + "])");
                return null;
            }

            return pwFields;
        },
        /*
         * _getFormFields
         *
         * Returns the username and password fields found in the form.
         * Can handle complex forms by trying to figure out what the
         * relevant fields are.
         *
         * Returns: [usernameField, newPasswordField, oldPasswordField]
         *
         * usernameField may be null.
         * newPasswordField will always be non-null.
         * oldPasswordField may be null. If null, newPasswordField is just
         * "theLoginField". If not null, the form is apparently a
         * change-password field, with oldPasswordField containing the password
         * that is being changed.
         */
        getFormFields: function (form, isSubmission) {
            var usernameField = null;

            // Locate the password field(s) in the form. Up to 3 supported.
            // If there's no password field, there's nothing for us to do.
            var pwFields = this._getPasswordFields(form, isSubmission);
            if (!pwFields){
                return [null, null, null];
            }


            // Locate the username field in the form by searching backwards
            // from the first passwordfield, assume the first text field is the
            // username. We might not find a username field if the user is
            // already logged in to the site.
            for (var i = pwFields[0].index - 1; i >= 0; i--) {
                if (form.elements[i].type.toLowerCase() === "text" || form.elements[i].type.toLowerCase() === "email") {
                    usernameField = form.elements[i];
                    break;
                }
            }

            if (!usernameField){
                this.log('(form ('+ form.action +') ignored -- no username field found)');
            }


            // If we're not submitting a form (it's a page load), there are no
            // password field values for us to use for identifying fields. So,
            // just assume the first password field is the one to be filled in.
            if (!isSubmission || pwFields.length === 1){
                var res = [usernameField, pwFields[0].element];
                if(pwFields[1]){
                    res.push(pwFields[1].element);
                } else {
                    res.push(null);
                }
                return res;
            }



            // Try to figure out WTF is in the form based on the password values.
            var oldPasswordField, newPasswordField;
            var pw1 = pwFields[0].element.value;
            var pw2 = pwFields[1].element.value;
            var pw3 = (pwFields[2] ? pwFields[2].element.value : null);

            if (pwFields.length === 3) {
                // Look for two identical passwords, that's the new password

                if (pw1 === pw2 && pw2 === pw3) {
                    // All 3 passwords the same? Weird! Treat as if 1 pw field.
                    newPasswordField = pwFields[0].element;
                    oldPasswordField = null;
                } else if (pw1 === pw2) {
                    newPasswordField = pwFields[0].element;
                    oldPasswordField = pwFields[2].element;
                } else if (pw2 === pw3) {
                    oldPasswordField = pwFields[0].element;
                    newPasswordField = pwFields[2].element;
                } else if (pw1 === pw3) {
                    // A bit odd, but could make sense with the right page layout.
                    newPasswordField = pwFields[0].element;
                    oldPasswordField = pwFields[1].element;
                } else {
                    // We can't tell which of the 3 passwords should be saved.
                    this.log("(form ignored -- all 3 pw fields differ)");
                    return [null, null, null];
                }
            } else { // pwFields.length == 2
                if (pw1 === pw2) {
                    // Treat as if 1 pw field
                    newPasswordField = pwFields[0].element;
                    oldPasswordField = null;
                } else {
                    // Just assume that the 2nd password is the new password
                    oldPasswordField = pwFields[0].element;
                    newPasswordField = pwFields[1].element;
                }
            }

            return [usernameField, newPasswordField, oldPasswordField];
        },
        log: function (str) {
            if(settings.debug){
                console.log(str);

            }
        }
    };
}();

function getLoginFields(isSubmission) {
    var forms = document.forms;
    var loginForms = [];

    for (var i = 0; i < forms.length; i++) {
        var form = forms[i];
        var result = formManager.getFormFields(form, isSubmission);
        var usernameField = result[0];
        var passwordField = result[1];
        // Need a valid password field to do anything.
        if (passwordField === null){
            continue;
        }

        var res = [usernameField, passwordField];
        if(result[2]){
            res.push(result[2]);
        } else {
            res.push(null);
        }
        loginForms.push(res);
    }
    return loginForms;
}

function getFormFromElement(elem) {
    if(elem) {
function isBig(a) {
    if (a > 5000) {
        return "yes";
    }
}

console.log(isBig(5001)); //returns yes
console.log(isBig(42)); //returns undefined
        while (elem.parentNode) {
            if (elem.parentNode.nodeName.toLowerCase() === "form") {
                return elem.parentNode;
            }
            elem = elem.parentNode;
        }

    }
}

function dispatchEvents(element){
    var eventNames = [ 'click', 'focus', 'keypress', 'keydown', 'keyup', 'input', 'blur', 'change' ];
    eventNames.forEach(function(eventName) {
        element.dispatchEvent(new Event(eventName, {"bubbles":true}));

    });
}

function fillPassword(user, password) {
    var loginFields = getLoginFields();
    for (var i = 0; i < loginFields.length; i++) {
        if(user && loginFields[i][0]){
            loginFields[i][0].value = user;
            if(loginFields[i][0].offsetParent) {
                dispatchEvents(loginFields[i][0]);
            }
        }
        if(password && loginFields[i][1]) {
            loginFields[i][1].value = password;
            if(loginFields[i][1].offsetParent) {
                dispatchEvents(loginFields[i][1]);
            }
        }
        if(password && loginFields[i][2]) {
            loginFields[i][2].value = password;
            if(loginFields[i][2].offsetParent) {
                dispatchEvents(loginFields[i][2]);
            }
        }
    }

}
formManager._init_();

1			var formManager = function(){
2			/**
3			Code based on:
4			@url https://dxr.mozilla.org/firefox/source/toolkit/components/passwordmgr/src/nsLoginManager.js#655
5			*/
6			var settings = {};
7
8			return {
9			_init_: function () {
10			API.runtime.sendMessage(API.runtime.id, {method: 'getSetting', args: 'debug'}).then(function (result) {
11			settings.debug = (result);
12			});
13			},
14			/*
15			* _isAutoCompleteDisabled
16			*
17			* Returns true if the page requests autocomplete be disabled for the
18			* specified form input.
19			*/
20			isAutocompleteDisabled: function (element) {
21			return !!(element && element.hasAttribute("autocomplete") && element.getAttribute("autocomplete").toLowerCase() === "off");
22			},
23
24			/*
25			* _getPasswordFields
26			*
27			* Returns an array of password field elements for the specified form.
28			* If no pw fields are found, or if more than 3 are found, then null
29			* is returned.
30			*
31			* skipEmptyFields can be set to ignore password fields with no value.
32			*/
33			_getPasswordFields: function (form, skipEmptyFields) {
34			// Locate the password fields in the form.
35			var pwFields = [];
36			for (var i = 0; i < form.elements.length; i++) {
37			if (form.elements[i].type !== "password"){
38			continue;
39			}
40
41
42			if (skipEmptyFields && !form.elements[i].value){
43			continue;
44			}
45
46			pwFields[pwFields.length] = {
47			index: i,
48			element: form.elements[i]
49			};
50			}
51
52			// If too few or too many fields, bail out.
53			if (pwFields.length === 0) {
54			this.log('(form ignored ('+ form.action +') -- no password fields.)');
55			return null;
56			} else if (pwFields.length > 3) {
57			this.log('(form ignored -- too many password fields. [got ' +
58			pwFields.length + "])");
59			return null;
60			}
61
62			return pwFields;
63			},
64			/*
65			* _getFormFields
66			*
67			* Returns the username and password fields found in the form.
68			* Can handle complex forms by trying to figure out what the
69			* relevant fields are.
70			*
71			* Returns: [usernameField, newPasswordField, oldPasswordField]
72			*
73			* usernameField may be null.
74			* newPasswordField will always be non-null.
75			* oldPasswordField may be null. If null, newPasswordField is just
76			* "theLoginField". If not null, the form is apparently a
77			* change-password field, with oldPasswordField containing the password
78			* that is being changed.
79			*/
80			getFormFields: function (form, isSubmission) {
81			var usernameField = null;
82
83			// Locate the password field(s) in the form. Up to 3 supported.
84			// If there's no password field, there's nothing for us to do.
85			var pwFields = this._getPasswordFields(form, isSubmission);
86			if (!pwFields){
87			return [null, null, null];
88			}
89
90
91			// Locate the username field in the form by searching backwards
92			// from the first passwordfield, assume the first text field is the
93			// username. We might not find a username field if the user is
94			// already logged in to the site.
95			for (var i = pwFields[0].index - 1; i >= 0; i--) {
96			if (form.elements[i].type.toLowerCase() === "text" \|\| form.elements[i].type.toLowerCase() === "email") {
97			usernameField = form.elements[i];
98			break;
99			}
100			}
101
102			if (!usernameField){
103			this.log('(form ('+ form.action +') ignored -- no username field found)');
104			}
105
106
107			// If we're not submitting a form (it's a page load), there are no
108			// password field values for us to use for identifying fields. So,
109			// just assume the first password field is the one to be filled in.
110			if (!isSubmission \|\| pwFields.length === 1){
111			var res = [usernameField, pwFields[0].element];
112			if(pwFields[1]){
113			res.push(pwFields[1].element);
114			} else {
115			res.push(null);
116			}
117			return res;
118			}
119
120
121
122			// Try to figure out WTF is in the form based on the password values.
123			var oldPasswordField, newPasswordField;
124			var pw1 = pwFields[0].element.value;
125			var pw2 = pwFields[1].element.value;
126			var pw3 = (pwFields[2] ? pwFields[2].element.value : null);
127
128			if (pwFields.length === 3) {
129			// Look for two identical passwords, that's the new password
130
131			if (pw1 === pw2 && pw2 === pw3) {
132			// All 3 passwords the same? Weird! Treat as if 1 pw field.
133			newPasswordField = pwFields[0].element;
134			oldPasswordField = null;
135			} else if (pw1 === pw2) {
136			newPasswordField = pwFields[0].element;
137			oldPasswordField = pwFields[2].element;
138			} else if (pw2 === pw3) {
139			oldPasswordField = pwFields[0].element;
140			newPasswordField = pwFields[2].element;
141			} else if (pw1 === pw3) {
142			// A bit odd, but could make sense with the right page layout.
143			newPasswordField = pwFields[0].element;
144			oldPasswordField = pwFields[1].element;
145			} else {
146			// We can't tell which of the 3 passwords should be saved.
147			this.log("(form ignored -- all 3 pw fields differ)");
148			return [null, null, null];
149			}
150			} else { // pwFields.length == 2
151			if (pw1 === pw2) {
152			// Treat as if 1 pw field
153			newPasswordField = pwFields[0].element;
154			oldPasswordField = null;
155			} else {
156			// Just assume that the 2nd password is the new password
157			oldPasswordField = pwFields[0].element;
158			newPasswordField = pwFields[1].element;
159			}
160			}
161
162			return [usernameField, newPasswordField, oldPasswordField];
163			},
164			log: function (str) {
165			if(settings.debug){
166			console.log(str);
			0 ignored issues – show Debugging Code introduced 2017-04-15 12:32 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
167			}
168			}
169			};
170			}();
171
172			function getLoginFields(isSubmission) {
173			var forms = document.forms;
174			var loginForms = [];
175
176			for (var i = 0; i < forms.length; i++) {
177			var form = forms[i];
178			var result = formManager.getFormFields(form, isSubmission);
179			var usernameField = result[0];
180			var passwordField = result[1];
181			// Need a valid password field to do anything.
182			if (passwordField === null){
183			continue;
184			}
185
186			var res = [usernameField, passwordField];
187			if(result[2]){
188			res.push(result[2]);
189			} else {
190			res.push(null);
191			}
192			loginForms.push(res);
193			}
194			return loginForms;
195			}
196
197			function getFormFromElement(elem) {
198			if(elem) {
			0 ignored issues – show Complexity Best Practice introduced 2017-04-17 10:15 UTC by Report Bug Copy Issue Report There is no return statement if `elem` is `false`. Are you sure this is correct? If so, consider adding `return;` explicitly. This check looks for functions where a `return` statement is found in some execution paths, but not in all. Consider this little piece of code function isBig(a) { if (a > 5000) { return "yes"; } } console.log(isBig(5001)); //returns yes console.log(isBig(42)); //returns undefined The function `isBig` will only return a specific value when its parameter is bigger than 5000. In any other case, it will implicitly return `undefined`. This behaviour may not be what you had intended. In any case, you can add a `return undefined` to the other execution path to make the return value explicit. Loading history...
199			while (elem.parentNode) {
200			if (elem.parentNode.nodeName.toLowerCase() === "form") {
201			return elem.parentNode;
202			}
203			elem = elem.parentNode;
204			}
			0 ignored issues – show Best Practice introduced 2017-06-02 12:49 UTC by Report Bug Copy Issue Report There is no `return` statement in this branch, but you do return something in other branches. Did you maybe miss it? If you do not want to return anything, consider adding `return undefined;` explicitly. Loading history...
205			}
206			}
207
208			function dispatchEvents(element){
209			var eventNames = [ 'click', 'focus', 'keypress', 'keydown', 'keyup', 'input', 'blur', 'change' ];
210			eventNames.forEach(function(eventName) {
211			element.dispatchEvent(new Event(eventName, {"bubbles":true}));
			0 ignored issues – show Bug introduced 2017-06-02 12:49 UTC by Report Bug Copy Issue Report The variable `Event` seems to be never declared. If this is a global, consider adding a `/** global: Event */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
212			});
213			}
214
215			function fillPassword(user, password) {
216			var loginFields = getLoginFields();
217			for (var i = 0; i < loginFields.length; i++) {
218			if(user && loginFields[i][0]){
219			loginFields[i][0].value = user;
220			if(loginFields[i][0].offsetParent) {
221			dispatchEvents(loginFields[i][0]);
222			}
223			}
224			if(password && loginFields[i][1]) {
225			loginFields[i][1].value = password;
226			if(loginFields[i][1].offsetParent) {
227			dispatchEvents(loginFields[i][1]);
228			}
229			}
230			if(password && loginFields[i][2]) {
231			loginFields[i][2].value = password;
232			if(loginFields[i][2].offsetParent) {
233			dispatchEvents(loginFields[i][2]);
234			}
235			}
236			}
237
238			}
239			formManager._init_();

nextcloud / passman-webextension

Pull Request — master (#161)

formManager.constructor B

Complexity

Size

Duplication

Importance

6 Functions

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like